Author rhettinger
Recipients barry, eric.smith, eric.snow, llllllllll, rhettinger, serhiy.storchaka
Date 2015-04-29.16:26:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1430324767.09.0.575109155236.issue23910@psf.upfronthosting.co.za>
In-reply-to
Content
>  0.0699 usec per loop --> 0.0468 

That's pretty good for a small patch :-)


For the pre-computed 1-tuple, I think you need to check for a refcnt of 1 and fallback to PyTuple_New if the tuple is in use (i.e. a property that calls another property).  See Objects/enumobject.c::105 for an example.

Also, consider providing a way to clean-up that tuple on shutdown.  For example, look at what is done with the various freelists.  An easier way is to make the premade tuple part of the property object struct so that it gets freed when the property is deallocated.

Adding Serhiy to the nosy list, he can help with cleaning-up the patch so that it is ready to apply.
History
Date User Action Args
2015-04-29 16:26:07rhettingersetrecipients: + rhettinger, barry, eric.smith, eric.snow, serhiy.storchaka, llllllllll
2015-04-29 16:26:07rhettingersetmessageid: <1430324767.09.0.575109155236.issue23910@psf.upfronthosting.co.za>
2015-04-29 16:26:07rhettingerlinkissue23910 messages
2015-04-29 16:26:06rhettingercreate