Author bobcatfish
Recipients BreamoreBoy, Rodrigue.Alcazar, berker.peksag, bobcatfish, ezio.melotti, flipmcf, michael.foord, ncoghlan, pitrou, r.david.murray, serhiy.storchaka
Date 2015-04-24.01:01:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1429837274.66.0.744496859586.issue9517@psf.upfronthosting.co.za>
In-reply-to
Content
Hey @berker.peksag, I've added a new patch in response to your review!

> You should create the patch with "hg diff --git" to preserve moving. And then apply it with "hg import", not the patch command. Unfortunately Rietveld don't like patches in git format.

Ick, I'm guessing it's okay to just use plain old "hg diff" then, if Rietveld doesn't like the patches in git format.
History
Date User Action Args
2015-04-24 01:01:15bobcatfishsetrecipients: + bobcatfish, ncoghlan, pitrou, ezio.melotti, r.david.murray, michael.foord, BreamoreBoy, Rodrigue.Alcazar, berker.peksag, serhiy.storchaka, flipmcf
2015-04-24 01:01:14bobcatfishsetmessageid: <1429837274.66.0.744496859586.issue9517@psf.upfronthosting.co.za>
2015-04-24 01:01:14bobcatfishlinkissue9517 messages
2015-04-24 01:01:14bobcatfishcreate