Message241899
The items on the stack are created in two ways: [], and self._dict_type().
Currently the code assumes that self._dict_type() returns an object that passes isinstance(..., type({})). I suggested the following two ways to improve this check:
- Replace with: isinstance(..., self._dict_type)
- Replace with: not isinstance(..., type([]))
Feel free to close. I reported because I saw room for improvement. I don't /need/ the change myself.
Thanks. |
|
Date |
User |
Action |
Args |
2015-04-23 23:53:08 | Behdad.Esfahbod | set | recipients:
+ Behdad.Esfahbod, ronaldoussoren, ned.deily |
2015-04-23 23:53:08 | Behdad.Esfahbod | set | messageid: <1429833188.89.0.977618341261.issue24040@psf.upfronthosting.co.za> |
2015-04-23 23:53:08 | Behdad.Esfahbod | link | issue24040 messages |
2015-04-23 23:53:08 | Behdad.Esfahbod | create | |
|