Message241107
Some small comments:
* diff_bytes needs to be documented in the difflib docs and in Doc/whatsnew/3.5.rst.
* diff_bytes needs to be added to difflib.__all__
* This looks like a new feature to me, so it would be better to just commit it to the default branch.
+ except AttributeError:
+ raise TypeError('all arguments must be bytes, not %r' % s)
This could be changed to raise TypeError(...) from None
+ self.assertTrue(
+ isinstance(line, bytes),
assertIsInstance
+ try:
+ list(difflib.unified_diff(a, b, fna, fnb))
+ self.fail('expected TypeError')
+ except TypeError:
+ pass
with self.assertRaises(TypeError):
list(difflib.unified_diff(a, b, fna, fnb))
looks more readable to me. |
|
Date |
User |
Action |
Args |
2015-04-15 14:36:18 | berker.peksag | set | recipients:
+ berker.peksag, barry, gward, terry.reedy, ncoghlan, pitrou, durin42, r.david.murray |
2015-04-15 14:36:18 | berker.peksag | set | messageid: <1429108578.46.0.629788467458.issue17445@psf.upfronthosting.co.za> |
2015-04-15 14:36:18 | berker.peksag | link | issue17445 messages |
2015-04-15 14:36:18 | berker.peksag | create | |
|