Author r.david.murray
Recipients Yuri.Bochkarev, agriffis, alanjds, amak, berker.peksag, cananian, demian.brecht, icordasc, jcea, jhylton, martin.panter, mhammond, orsenthil, python-dev, r.david.murray, rbcollins
Date 2015-04-05.23:34:37
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1428276878.07.0.686464062122.issue3566@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks, Martin and Demian.  I tweaked the patch slightly before commit, so I've uploaded the diff.  After thinking about it I decided that it does indeed make sense that the new exception subclass both ConnectionResetError and BadStatusLine, exactly because it *isn't* a pure ConnectionError, it is a synthetic one based on getting a '' response when we are expecting a status line.  So I tweaked the language to not mention backward compatibility.  I also tweaked the language of the docs, comments and error message to make it clear that the issue is that the server closed the connection (I understand why you changed it to 'shut down', but I think 'the server closed the connection' is both precise enough and more intuitive).

If you have any issues with the changes I made, let me know.
History
Date User Action Args
2015-04-05 23:34:38r.david.murraysetrecipients: + r.david.murray, jhylton, mhammond, jcea, orsenthil, amak, rbcollins, cananian, alanjds, agriffis, python-dev, berker.peksag, martin.panter, icordasc, demian.brecht, Yuri.Bochkarev
2015-04-05 23:34:38r.david.murraysetmessageid: <1428276878.07.0.686464062122.issue3566@psf.upfronthosting.co.za>
2015-04-05 23:34:38r.david.murraylinkissue3566 messages
2015-04-05 23:34:37r.david.murraycreate