➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients neologix, pitrou, python-dev, serhiy.storchaka, vstinner
Date 2015-03-24.11:23:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1427196215.42.0.543109063354.issue23753@psf.upfronthosting.co.za>
In-reply-to
Content 
> -#if defined(HAVE_STAT) && !defined(MS_WINDOWS)
> This doesn't look correct. An equivalent replacement is 

Oh, I missed the "!". Only _Py_wstat() uses this test. Windows has _wstat(), so _Py_wstat() could use it.

I added deliberately "!defined(MS_WINDOWS)" because _Py_wstat() is only used in Modules/getpath.c and this file is not compiled on Windows.

Instead of modifying _Py_wstat(), I moved it back to Modules/getpath.c. There is no need to overengineer this function only called 3 times in getpath.c.
History
Date User Action Args
2015-03-24 11:23:35vstinnersetrecipients: + vstinner, pitrou, neologix, python-dev, serhiy.storchaka
2015-03-24 11:23:35vstinnersetmessageid: <1427196215.42.0.543109063354.issue23753@psf.upfronthosting.co.za>
2015-03-24 11:23:35vstinnerlinkissue23753 messages
2015-03-24 11:23:35vstinnercreate