Message238250
Posting LZMAFile-etc.v5.patch with the following changes:
* Merged with current code
* Changed BZ2File(buffer_size=...) to a keyword-only parameter and restored previous unused “buffering” parameter. Also changed the LZMAFile parameter to keyword-only for consistency.
* Dropped documenting how buffer_size affects the compressed data chunk size or the fast-forward chunk size for seeking
* Dropped backslash from \* in function signatures
* Documented and tested that buffer_size=0 is not valid for the LZMAFile etc classes
* Clarified a few code comments
There is still Nikolaus’s concern about setting the buffer size to zero and doing short reads, discussed on Rietveld. Apart from that, I think this patch addresses the rest of the comments. Let me know if I missed something! |
|
Date |
User |
Action |
Args |
2015-03-16 23:59:38 | martin.panter | set | recipients:
+ martin.panter, pitrou, Arfrever, nikratio, serhiy.storchaka |
2015-03-16 23:59:37 | martin.panter | set | messageid: <1426550377.32.0.0173453916865.issue23529@psf.upfronthosting.co.za> |
2015-03-16 23:59:37 | martin.panter | link | issue23529 messages |
2015-03-16 23:59:37 | martin.panter | create | |
|