This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients Arfrever, martin.panter, nikratio, pitrou, serhiy.storchaka
Date 2015-03-16.23:59:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1426550377.32.0.0173453916865.issue23529@psf.upfronthosting.co.za>
In-reply-to
Content
Posting LZMAFile-etc.v5.patch with the following changes:

* Merged with current code
* Changed BZ2File(buffer_size=...) to a keyword-only parameter and restored previous unused “buffering” parameter. Also changed the LZMAFile parameter to keyword-only for consistency.
* Dropped documenting how buffer_size affects the compressed data chunk size or the fast-forward chunk size for seeking
* Dropped backslash from \* in function signatures
* Documented and tested that buffer_size=0 is not valid for the LZMAFile etc classes
* Clarified a few code comments

There is still Nikolaus’s concern about setting the buffer size to zero and doing short reads, discussed on Rietveld. Apart from that, I think this patch addresses the rest of the comments. Let me know if I missed something!
History
Date User Action Args
2015-03-16 23:59:38martin.pantersetrecipients: + martin.panter, pitrou, Arfrever, nikratio, serhiy.storchaka
2015-03-16 23:59:37martin.pantersetmessageid: <1426550377.32.0.0173453916865.issue23529@psf.upfronthosting.co.za>
2015-03-16 23:59:37martin.panterlinkissue23529 messages
2015-03-16 23:59:37martin.pantercreate