Author kilowu
Recipients kilowu, python-dev, vstinner
Date 2015-03-13.18:06:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1426269965.68.0.579317814874.issue23566@psf.upfronthosting.co.za>
In-reply-to
Content
The last approach I proposed requires some change in "template code" of check_xxx methods. To make it better, we can add a bool parameter to the check_xxx functions, True value indicating a fd test. If a filename is given at the same time, then a fd can get from that file. Otherwise the fd should be sys.stderr.fileno().

e.g.
file = None
fp = None
if filename:
    fp = open(filename, "wb")
    # Must use a different name to prevent the file from closing...
    file = fp
if fd:
    if fp is not None:
        file = fp.fileno()
    else:
        file = sys.stderr.fileno()

# file can be file-object, fd or None
(use_the_file_to_function...)


The fd-passing approach can co-exist with this one. However it will make "template code" more complex. So I suggest just use one approach to write these fd tests.

I will work on a patch(based on tip) at this weekend.
History
Date User Action Args
2015-03-13 18:06:05kilowusetrecipients: + kilowu, vstinner, python-dev
2015-03-13 18:06:05kilowusetmessageid: <1426269965.68.0.579317814874.issue23566@psf.upfronthosting.co.za>
2015-03-13 18:06:05kilowulinkissue23566 messages
2015-03-13 18:06:05kilowucreate