Message237848
Posting a new patch with the following changes:
* Added Poleto’s original tests, updated according to review comments. Combined the flag and source code string parameters.
* Used a different approach to guessing where the offending ImportError came from. Now it checks if the module got added to sys.modules, which seems to work in all cases I tried. It no longer does what the bug title says (check ImportError.name), but I think it is a better workaround or fix for the underlying problem.
* Removed Poleto’s “Error executing package . . .” ImportError wrapper. We already know what package we are trying to execute, and it hasn’t actually been “executed” yet, because __init__.py failed.
* Cleaned up exception name in the “Error while finding spec” message |
|
Date |
User |
Action |
Args |
2015-03-11 08:13:02 | martin.panter | set | recipients:
+ martin.panter, ncoghlan, r.david.murray, eric.snow, Anthony.Kong, berker.peksag, Fotis.Koutoulakis, luiz.poleto |
2015-03-11 08:13:02 | martin.panter | set | messageid: <1426061582.32.0.380862106193.issue19771@psf.upfronthosting.co.za> |
2015-03-11 08:13:02 | martin.panter | link | issue19771 messages |
2015-03-11 08:13:02 | martin.panter | create | |
|