Author martin.panter
Recipients andymaier, benjamin.peterson, chris.jerdonek, cvrebert, docs@python, ethan.furman, ezio.melotti, gvanrossum, mark.dickinson, martin.panter, mikehoy, rhettinger, steven.daprano, terry.reedy
Date 2015-02-20.11:00:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1424430009.85.0.0999751883095.issue12067@psf.upfronthosting.co.za>
In-reply-to
Content
Issue 4395 is already open for the != delegating to __eq__ issue that Guido pointed out earlier.

Yet another issue that this doc patch should solve: Issue 22000.

I am posting v13 of the patch that works with the current “default” (3.5) branch. Minor modifications to the documentation part:

* Undo some paragraph reflowing to reduce the size of the diff hunks
* Use math.nan instead of nan = float('NaN')
* Tweaked the new subheadings to better differentiate “Value comparisons” (which this bug is concerned with) from “Identity comparisons”

Changes I made to the added test cases:

* Drop Python 3 version check
* Use TestCase.subTest() so it’s easier to see everything that [is] was failing
* Merge some tests for != and fix changed expectations due to Issue 21408 being fixed
* Drop _inst_str() and __str__(), apparently unused

It would be nice to see at least the documentation part reviewed and committed, even if the tests require more work. (After having to hack the tests to get them working, I might point out some odd bits in the code review.) Though I guess they are just tests, so it doesn’t matter so much as long as they pass.
History
Date User Action Args
2015-02-20 11:00:12martin.pantersetrecipients: + martin.panter, gvanrossum, rhettinger, terry.reedy, mark.dickinson, benjamin.peterson, ezio.melotti, steven.daprano, cvrebert, chris.jerdonek, docs@python, ethan.furman, mikehoy, andymaier
2015-02-20 11:00:09martin.pantersetmessageid: <1424430009.85.0.0999751883095.issue12067@psf.upfronthosting.co.za>
2015-02-20 11:00:09martin.panterlinkissue12067 messages
2015-02-20 11:00:09martin.pantercreate