Author demian.brecht
Recipients berker.peksag, demian.brecht, martin.panter
Date 2015-02-13.01:13:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <54DD4FB0.5020504@gmail.com>
In-reply-to <1423778942.53.0.328079927645.issue23439@psf.upfronthosting.co.za>
Content
> If we leave it as it is, it would be good to add comment in the source code explaining this decision.
I think that __all__ should be left as-is for the time being. Adding
some comments around that decision makes sense to me to avoid any future
confusion around that.

> Also the test case could still be useful to catch future bugs.
Agreed. I've added a couple minor comments to the review.

Thanks for the work on this!
History
Date User Action Args
2015-02-13 01:13:27demian.brechtsetrecipients: + demian.brecht, berker.peksag, martin.panter
2015-02-13 01:13:27demian.brechtlinkissue23439 messages
2015-02-13 01:13:27demian.brechtcreate