Author vstinner
Recipients abacabadabacaba, akira, benhoyt, giampaolo.rodola, josh.r, pitrou, socketpair, tebeka, tim.golden, vstinner
Date 2015-02-12.17:25:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1423761951.86.0.162200728226.issue22524@psf.upfronthosting.co.za>
In-reply-to
Content
Patch version 5:

- Use None value for the d_type instead of DT_UNKNOW to *prepare* support for platforms where the dirent structure has no d_type field. Serhiy guess that such platform have no DT_xxx constant neither. DirEntry doesn't DT_xxx constants if d_type is None

- Fix test_removed_file() and test_removed_dir() tests if d_type is unknown (I tested manually by forcing d_type to None)

- Use os.lstat() instead of os.stat(follow_symlinks=False) in DirEntry.inode(), it's a little bit faster even if it's the same syscall. The cost probably comes from the code parsing Python parameters, especially the keyword
History
Date User Action Args
2015-02-12 17:25:53vstinnersetrecipients: + vstinner, tebeka, pitrou, giampaolo.rodola, tim.golden, benhoyt, abacabadabacaba, akira, socketpair, josh.r
2015-02-12 17:25:51vstinnersetmessageid: <1423761951.86.0.162200728226.issue22524@psf.upfronthosting.co.za>
2015-02-12 17:25:51vstinnerlinkissue22524 messages
2015-02-12 17:25:51vstinnercreate