This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients Arfrever, pkt, python-dev, serhiy.storchaka
Date 2015-02-02.07:05:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1422860708.04.0.140205429116.issue23366@psf.upfronthosting.co.za>
In-reply-to
Content
This commit (and three other) causes compiler warnings:

./Modules/itertoolsmodule.c: In function ‘product_new’:
./Modules/itertoolsmodule.c:2025:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         if (repeat > PY_SSIZE_T_MAX/sizeof(Py_ssize_t) ||
                    ^
./Modules/itertoolsmodule.c:2026:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             nargs > PY_SSIZE_T_MAX/(repeat * sizeof(Py_ssize_t))) {
                   ^
./Modules/itertoolsmodule.c: In function ‘combinations_new’:
./Modules/itertoolsmodule.c:2371:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (r > PY_SSIZE_T_MAX/sizeof(Py_ssize_t)) {
           ^
./Modules/itertoolsmodule.c: In function ‘cwr_new’:
./Modules/itertoolsmodule.c:2716:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (r > PY_SSIZE_T_MAX/sizeof(Py_ssize_t)) {
           ^
./Modules/itertoolsmodule.c: In function ‘permutations_new’:
./Modules/itertoolsmodule.c:3061:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (n > PY_SSIZE_T_MAX/sizeof(Py_ssize_t) ||
           ^
./Modules/itertoolsmodule.c:3062:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         r > PY_SSIZE_T_MAX/sizeof(Py_ssize_t)) {
           ^

May be use PyMem_New instead of PyMem_Malloc?
History
Date User Action Args
2015-02-02 07:05:08serhiy.storchakasetrecipients: + serhiy.storchaka, Arfrever, python-dev, pkt
2015-02-02 07:05:08serhiy.storchakasetmessageid: <1422860708.04.0.140205429116.issue23366@psf.upfronthosting.co.za>
2015-02-02 07:05:08serhiy.storchakalinkissue23366 messages
2015-02-02 07:05:07serhiy.storchakacreate