Author serhiy.storchaka
Recipients serhiy.storchaka
Date 2015-01-28.22:22:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1422483726.85.0.28053556963.issue23344@psf.upfronthosting.co.za>
In-reply-to
Content
Currently writing marshalled data to buffer is not very efficient. Data is written byte by byte with testing conditions p->fp != NULL and p->ptr != p->end for every byte. Proposed patch makes writing to buffer faster.

Benchmark results:

$ ./python -m timeit -s "import marshal; d = compile(open('Lib/_pydecimal.py').read(), '_pydecimal.py', 'exec')" -- "marshal.dumps(d)"
Unpatched: 100 loops, best of 3: 4.64 msec per loop
Patched: 100 loops, best of 3: 3.39 msec per loop

$ ./python -m timeit -s "import marshal; a = ['%010x' % i for i in range(10**4)]" -- "marshal.dumps(a)"
Unpatched: 1000 loops, best of 3: 1.96 msec per loop
Patched: 1000 loops, best of 3: 1.32 msec per loop

$ ./python -m timeit -s "import marshal; a = ['%0100x' % i for i in range(10**4)]" -- "marshal.dumps(a)"
Unpatched: 100 loops, best of 3: 10.3 msec per loop
Patched: 100 loops, best of 3: 3.39 msec per loop
History
Date User Action Args
2015-01-28 22:22:06serhiy.storchakasetrecipients: + serhiy.storchaka
2015-01-28 22:22:06serhiy.storchakasetmessageid: <1422483726.85.0.28053556963.issue23344@psf.upfronthosting.co.za>
2015-01-28 22:22:06serhiy.storchakalinkissue23344 messages
2015-01-28 22:22:06serhiy.storchakacreate