This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author berker.peksag
Recipients BreamoreBoy, benjamin.peterson, berker.peksag, brett.cannon, demian.brecht, guohua, nikratio, orsenthil, python-dev, serhiy.storchaka
Date 2015-01-25.01:34:21
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1422149662.14.0.363134835129.issue23300@psf.upfronthosting.co.za>
In-reply-to
Content
+        self.assertDictEqual(self.conn._tunnel_headers, tunnel_headers)

You could just use assertEqual. Quoting from docs:

    "The list of type-specific methods automatically used by assertEqual() are summarized in the following table. Note that it’s usually not necessary to invoke these methods directly."

https://docs.python.org/3/library/unittest.html#unittest.TestCase.addTypeEqualityFunc

+        self.assertTrue(b'CONNECT destination.com' in self.conn.sock.data)
+        self.assertTrue(b'Host: destination.com' in self.conn.sock.data)

You could use assertIn instead.
History
Date User Action Args
2015-01-25 01:34:22berker.peksagsetrecipients: + berker.peksag, brett.cannon, orsenthil, benjamin.peterson, nikratio, BreamoreBoy, python-dev, serhiy.storchaka, demian.brecht, guohua
2015-01-25 01:34:22berker.peksagsetmessageid: <1422149662.14.0.363134835129.issue23300@psf.upfronthosting.co.za>
2015-01-25 01:34:22berker.peksaglinkissue23300 messages
2015-01-25 01:34:21berker.peksagcreate