This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author orsenthil
Recipients BreamoreBoy, benjamin.peterson, berker.peksag, brett.cannon, demian.brecht, guohua, nikratio, orsenthil, python-dev, serhiy.storchaka
Date 2015-01-25.00:43:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Actually, the same tests cannot be ported to 3.4 or default. httplib.HTTP class has been merged to HTTPConnection in 3.x and we don't allow a host, and port in connect().

There is good test coverage for verifying host, port in test_hort_port test in 3.x

However, I saw that TunnelTests could see some refactor and a test addition to cover the _tunnel_host, _tunnel_port attributes (which are set using _get_hostport method). 

Attaching a change to client.test_httplib which refactors TunnelTest and adds a new test called test_set_tunnel_host_port_headers. Please review if this change is Okay. I can push this in 3.4 and default branches.

Date User Action Args
2015-01-25 00:43:08orsenthilsetrecipients: + orsenthil, brett.cannon, benjamin.peterson, nikratio, BreamoreBoy, python-dev, berker.peksag, serhiy.storchaka, demian.brecht, guohua
2015-01-25 00:43:07orsenthilsetmessageid: <>
2015-01-25 00:43:07orsenthillinkissue23300 messages
2015-01-25 00:43:07orsenthilcreate