Author Al.Sweigart
Recipients Al.Sweigart, python-dev, terry.reedy
Date 2015-01-09.05:45:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
I've updated the patch.

I've removed the EditorWindow deletion. Importing that and using it as a class variable instead of using an assignment statement wasn't picked up. (Is there a more opaque way to do this import?)

I've left the change in. The frame variable name is (confusingly) reused:

        frame = frametable[fid]
        # ...cut for brevity...
        stack, i = self.idb.get_stack(frame, tb)
        stack = [(wrap_frame(frame), k) for frame, k in stack]

Changed to:

        # ...cut for brevity...
        stack, i = self.idb.get_stack(frametable[fid], tb)
        stack = [(wrap_frame(frame), k) for frame, k in stack]

The first use of frame is eliminated by simply using frametable[fid] instead. The second use is as the temporary variable inside the list comprehension, which means the "frame" name is reused. With this change, the only time the frame local variable is used is in the list comprehension. This gets rid of the name reuse and makes it a bit simpler.
Date User Action Args
2015-01-09 05:45:41Al.Sweigartsetrecipients: + Al.Sweigart, terry.reedy, python-dev
2015-01-09 05:45:41Al.Sweigartsetmessageid: <>
2015-01-09 05:45:41Al.Sweigartlinkissue23184 messages
2015-01-09 05:45:40Al.Sweigartcreate