Message233419
The metadata adjustments in Serhiy's patch had me thinking in terms of functools.wraps, but that rationale doesn't actually apply here (since the functions are only used in one place, and have a distinctive name rather than a generic one).
I'd also missed that the conversion to standalone module level functions inherently provides the same pickle compatibility benefit that Serhiy's patch did.
Accordingly, I agree that my suggested factory functions would make the code more complex for no benefit. |
|
Date |
User |
Action |
Args |
2015-01-04 14:19:08 | ncoghlan | set | recipients:
+ ncoghlan, rhettinger, python-dev, serhiy.storchaka |
2015-01-04 14:19:08 | ncoghlan | set | messageid: <1420381148.14.0.337777542859.issue23132@psf.upfronthosting.co.za> |
2015-01-04 14:19:08 | ncoghlan | link | issue23132 messages |
2015-01-04 14:19:08 | ncoghlan | create | |
|