Author ncoghlan
Recipients ncoghlan, python-dev, rhettinger, serhiy.storchaka
Date 2015-01-04.14:19:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1420381148.14.0.337777542859.issue23132@psf.upfronthosting.co.za>
In-reply-to
Content
The metadata adjustments in Serhiy's patch had me thinking in terms of functools.wraps, but that rationale doesn't actually apply here (since the functions are only used in one place, and have a distinctive name rather than a generic one).

I'd also missed that the conversion to standalone module level functions inherently provides the same pickle compatibility benefit that Serhiy's patch did.

Accordingly, I agree that my suggested factory functions would make the code more complex for no benefit.
History
Date User Action Args
2015-01-04 14:19:08ncoghlansetrecipients: + ncoghlan, rhettinger, python-dev, serhiy.storchaka
2015-01-04 14:19:08ncoghlansetmessageid: <1420381148.14.0.337777542859.issue23132@psf.upfronthosting.co.za>
2015-01-04 14:19:08ncoghlanlinkissue23132 messages
2015-01-04 14:19:08ncoghlancreate