This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author tim.golden
Recipients jnoller, sbt, steve.dower, tim.golden, zach.ware
Date 2014-12-16.08:50:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <548FF270.7010702@timgolden.me.uk>
In-reply-to <1418696995.02.0.22756137648.issue23060@psf.upfronthosting.co.za>
Content
I agree that this is a fragile assertion; it's too far removed from the
CreateFileMapping call which can generate it and almost impossible to
work around (in calling code) if it should fail in the way we're seeing
in the buildbot.

I think we're better off relying on a genuine exception bubbling up from
the CreateFileMapping/MapViewOfFile calls than trying to assert the
no-exception error return.

While the "preallocate self.buffer" hack you mention would probably have
the effect of preventing the assertion, it's really just adding another
layer of unwanted complexity. (And might still not work in some future
memory-allocation algorithm).

@Richard: if you're watching, have I missed anything?
History
Date User Action Args
2014-12-16 08:50:59tim.goldensetrecipients: + tim.golden, jnoller, sbt, zach.ware, steve.dower
2014-12-16 08:50:59tim.goldenlinkissue23060 messages
2014-12-16 08:50:58tim.goldencreate