Author demian.brecht
Recipients Aaron1011, a.badger, berker.peksag, demian.brecht, jcea, michael.foord
Date 2014-12-14.04:54:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1418532896.07.0.251816679875.issue23004@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the update, but this doesn't quite work either as you're assuming utf-8 (which is what .encode() and .decode() default to). For example, when using latin-1:

>>> m = mock_open(read_data= b'\xc6')
>>> with patch('__main__.open', m, create=True) :
...     with open('abc', 'rb') as f :
...         print(f.read())
...
Traceback (most recent call last):
  [snip]
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc6 in position 0: unexpected end of data

Additionally, a bytes object may simply be binary data that doesn't adhere to any specific encoding.

My suggestion is to remove the use of format() altogether as it's really not doing anything complex and simply append either '\n' or b'\n' depending on the type of object passed in. That way, you can deal with the type of object passed in directly without coercion.
History
Date User Action Args
2014-12-14 04:54:56demian.brechtsetrecipients: + demian.brecht, jcea, a.badger, michael.foord, berker.peksag, Aaron1011
2014-12-14 04:54:56demian.brechtsetmessageid: <1418532896.07.0.251816679875.issue23004@psf.upfronthosting.co.za>
2014-12-14 04:54:56demian.brechtlinkissue23004 messages
2014-12-14 04:54:54demian.brechtcreate