Author dstufft
Recipients alex, benjamin.peterson, christian.heimes, dstufft
Date 2014-11-23.05:27:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1416720465.5.0.373361245299.issue22921@psf.upfronthosting.co.za>
In-reply-to
Content
The SSLContext().wrap_socket() method allows you to pass in a server_hostname option which will be used for two purposes, it will be used as the server name for SNI and it will be used to verify the server name of the certificate. However currently if the OpenSSL you're using does not have SNI then sending the server_hostname option to wrap_socket() will raise a ValueError.

I think that instead server_hostname should always be accepted by SSLContext().wrap_socket() regardless of if SNI is available or if check_hostname is available. It's just going to be stored and used later so we can conditonally use it for SNI or for checking the hostname depending on if SNI is available or checking if a hostname is available. The way it works right now is that unless you're happy not working when SNI is not available you have to check the hostname yourself.

If we can fix this, I think it would be smart to do it ASAP and get it into Python 2.7.9 and backported to the various Python 3.x's so that in the near future it works with all recent versions of the various Pythons (though older micro releases it may not).

This shouldn't break any code since it's changing what used to be an error into a saner working case.
History
Date User Action Args
2014-11-23 05:27:45dstufftsetrecipients: + dstufft, christian.heimes, benjamin.peterson, alex
2014-11-23 05:27:45dstufftsetmessageid: <1416720465.5.0.373361245299.issue22921@psf.upfronthosting.co.za>
2014-11-23 05:27:45dstufftlinkissue22921 messages
2014-11-23 05:27:44dstufftcreate