Message231237
Thanks for the review, Serhiy. There isn't really a reason not to 'normalise' the Python step object to None when 1 is passed from C code, so I updated the patch to do that.
Regarding on-demand creation of the Python values, the problem is that C code that accesses the struct fields directly would not be prepared to find NULL values in them, so this would be a visible change and potential source of crashes. However, my guess is that this would rarely be a problem (see my last comment on changing the slice type internally). |
|
Date |
User |
Action |
Args |
2014-11-16 08:35:48 | scoder | set | recipients:
+ scoder, mark.dickinson, pitrou, serhiy.storchaka |
2014-11-16 08:35:48 | scoder | set | messageid: <1416126948.35.0.575050370102.issue18813@psf.upfronthosting.co.za> |
2014-11-16 08:35:48 | scoder | link | issue18813 messages |
2014-11-16 08:35:48 | scoder | create | |
|