Author ned.deily
Recipients Arfrever, David.Edelsohn, ned.deily, pitrou, vstinner
Date 2014-10-31.20:22:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1414786946.74.0.641663628503.issue22773@psf.upfronthosting.co.za>
In-reply-to
Content
The patch doesn't take into account that the readline module may be linked with BSD libedit (as is the default on OS X and is preferred by some third-party distributors) rather than GNU readline.  The patch causes the test to be incorrectly skipped on those platforms.

>>> readline._READLINE_VERSION
1026

The documented way of differentiating the two cases is by checking the __doc__ string for "readline" or "libedit":

>>> readline.__doc__
'Importing this module enables command line editing using libedit readline.'

vs.

>>> readline.__doc__
'Importing this module enables command line editing using GNU readline.'
History
Date User Action Args
2014-10-31 20:22:26ned.deilysetrecipients: + ned.deily, pitrou, vstinner, Arfrever, David.Edelsohn
2014-10-31 20:22:26ned.deilysetmessageid: <1414786946.74.0.641663628503.issue22773@psf.upfronthosting.co.za>
2014-10-31 20:22:26ned.deilylinkissue22773 messages
2014-10-31 20:22:26ned.deilycreate