Author terry.reedy
Recipients Saimadhav.Heblikar, gpolo, kbk, ned.deily, python-dev, taleinat, terry.reedy, weeble
Date 2014-10-15.02:49:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1413341393.45.0.66117152935.issue3068@psf.upfronthosting.co.za>
In-reply-to
Content
cfg-ext-34-4.diff:  In this patch, default values are classified as bool, int, on other.  An invalid user bool or int value is replaced by the corresponding default (which had to be a valid bool or int for the type to be set) and the invalid value is either removed or replaced by a valid value.  To this extent, this dialog will repair a corrupted config-extensions.cfg.  Int values get an entry box with validation.

The validation allows blank strings for int entries (which, of course are also allowed for 'other'.  All non-key options for default extensions must have a value.  So in set_user_value, if there is a default, a blank value is treated the same as if it were the default, and the user config line removed if there is one.  So blanking an entry is a way to set is to the default value.

I think this is about ready to commit.  It should first be tested with an added section in the user config for an added extension.  I also think set_user_value should be able to use the already fetched and saved default value.

S2: For patch 3, Rietveld shows all 5 files.  It momentarily showed 5 for patch 2, then reverted to just 1.
History
Date User Action Args
2014-10-15 02:49:54terry.reedysetrecipients: + terry.reedy, kbk, taleinat, gpolo, ned.deily, weeble, python-dev, Saimadhav.Heblikar
2014-10-15 02:49:53terry.reedysetmessageid: <1413341393.45.0.66117152935.issue3068@psf.upfronthosting.co.za>
2014-10-15 02:49:53terry.reedylinkissue3068 messages
2014-10-15 02:49:53terry.reedycreate