Author Saimadhav.Heblikar
Recipients Saimadhav.Heblikar, gpolo, kbk, ned.deily, python-dev, taleinat, terry.reedy, weeble
Date 2014-10-14.14:22:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1413296520.81.0.329814906724.issue3068@psf.upfronthosting.co.za>
In-reply-to
Content
1. Can we have more padding at the right end of the text widget? For me, it appears attached to the scrollbar.

2. Shortcut key for Configure extensions should be different from Configure Extensions. By this I mean, with the Options menu open, there is no way to open "Configure Extensions" using the keyboard.(Also see sidenote 1).

3. Is there a need for "..." after Configure Extensions? I am asking this as don't know why it was there for "Configure IDLE..." in the first place.

4. User extension config files are created even if extension config settings are not dirty. Clicking OK or Apply without changing anything creates them. 
Even if I change the setting for only 1 extension, extension config for all extensions are written to disk. This is unlike the behavior of "Configure IDLE" dialog.

5. There are a couple of places where Ok and Cancel are used. If I have understood PEP8 correctly, aren't they not following it? Should they be ok and cancel instead?

6. Is there a reason to comment out the unittest and Htest in configDialog.py?(Other than "application has been destroyed .." messages?)


Sidenote 1 : Options menu unreachable via keyboard shortcut because both format and options have "O" as the keyboard shortcut.

Sidenote 2: I am writing the review comments here as review tool does not detect all the files affected by this patch. Please confirm, so that I will post this issue to the developer list.

-- 
Regards
Saimadhav Heblikar
History
Date User Action Args
2014-10-14 14:22:00Saimadhav.Heblikarsetrecipients: + Saimadhav.Heblikar, terry.reedy, kbk, taleinat, gpolo, ned.deily, weeble, python-dev
2014-10-14 14:22:00Saimadhav.Heblikarsetmessageid: <1413296520.81.0.329814906724.issue3068@psf.upfronthosting.co.za>
2014-10-14 14:22:00Saimadhav.Heblikarlinkissue3068 messages
2014-10-14 14:22:00Saimadhav.Heblikarcreate