Author roippi
Recipients berker.peksag, rhettinger, roippi, stutzbach, tim.peters, vajrasky, vstinner, xdegaye
Date 2014-10-03.22:51:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1412376662.8.0.396871335193.issue19119@psf.upfronthosting.co.za>
In-reply-to
Content
That is one approach, of course, but imo pretty incomplete.  A test that is named "test_get_only" presumably would be expected to test __getitem__, not __cmp__.  Confusingly there is still a GetOnly item declared in the module, but it is not used.  Compare to test_len_only, which has a paired LenOnly class and test name.

Either GetOnly should be completely excised from the module and the test renamed to test_cmp_only (alternately test_cmp_err), or the GetOnly class should be fixed as in my patch.
History
Date User Action Args
2014-10-03 22:51:02roippisetrecipients: + roippi, tim.peters, rhettinger, vstinner, stutzbach, xdegaye, berker.peksag, vajrasky
2014-10-03 22:51:02roippisetmessageid: <1412376662.8.0.396871335193.issue19119@psf.upfronthosting.co.za>
2014-10-03 22:51:02roippilinkissue19119 messages
2014-10-03 22:51:02roippicreate