Author geertj
Recipients Ben.Darnell, alex, chatgris, christian.heimes, dstufft, ezio.melotti, geertj, giampaolo.rodola, gvanrossum, janssen, pitrou, sbt, vstinner, yselivanov
Date 2014-10-03.12:02:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1412337730.59.0.345520650683.issue21965@psf.upfronthosting.co.za>
In-reply-to
Content
> Well... I would have expected this approach to yield a bigger reduction in code size. If it doesn't shrink the code, then I'm not sure it's worthwhile. What do you think?

I think the improved test coverage might still make it worthwhile. All tests are now exercising the SSLObject methods via SSLSocket. Also it's more future proof as the risk is less that you'd add a new method to SSLSocket without adding it to SSLObject as well.

It's not clear cut. Either way is fine I think.

> (also, why do you have to add an "owner" attribute?)

That is to support the first argument passed to the sever name callback set with set_servername_callback(). This will be an SSLSocket or an SSLObject instance depending on who's using it.
History
Date User Action Args
2014-10-03 12:02:10geertjsetrecipients: + geertj, gvanrossum, janssen, pitrou, vstinner, giampaolo.rodola, christian.heimes, ezio.melotti, alex, sbt, Ben.Darnell, yselivanov, dstufft, chatgris
2014-10-03 12:02:10geertjsetmessageid: <1412337730.59.0.345520650683.issue21965@psf.upfronthosting.co.za>
2014-10-03 12:02:10geertjlinkissue21965 messages
2014-10-03 12:02:10geertjcreate