Message226928
But who says this isn't intended? I don't know why it was done this way, but the following reasoning might apply: we want to have a stable API for unpickling compiled regexps, but we want to be able to evolve the re.compile() API. Just the fact that '_compile' starts with an underscore doesn't mean that it may involve -- in fact, the fact that it is used by pickles says the opposite. Therefore I think the patch makes things worse (tying the pickle format to the public re.compile() method).
At best we should add a comment to _compile explaining that its API is constrained by pickle backward compatibility. |
|
Date |
User |
Action |
Args |
2014-09-15 17:25:14 | gvanrossum | set | recipients:
+ gvanrossum, pitrou, ezio.melotti, mrabarnett, serhiy.storchaka |
2014-09-15 17:25:14 | gvanrossum | set | messageid: <1410801914.49.0.341035227867.issue22416@psf.upfronthosting.co.za> |
2014-09-15 17:25:14 | gvanrossum | link | issue22416 messages |
2014-09-15 17:25:14 | gvanrossum | create | |
|