Message226726
> Modules/_json.c:1558: item = NULL;
> You can move it outside of the loop.
I prefer to set item to NULL just after PyList_SET_ITEM() to make it explicit that the list now owns the reference.
> But may be it will be better to make this "item" variable local.
"item" is also used below, and I don't want to have two "item" variables.
I commited my to Python 3.4 & 3.5.
Python 2.7 doesn't look to be affected, chunk and item are not cleared (Py_DECREF) in the error handler ("bail:" label).
Thanks for the review. |
|
Date |
User |
Action |
Args |
2014-09-10 21:37:27 | vstinner | set | recipients:
+ vstinner, python-dev, serhiy.storchaka |
2014-09-10 21:37:27 | vstinner | set | messageid: <1410385047.36.0.32864030754.issue22338@psf.upfronthosting.co.za> |
2014-09-10 21:37:27 | vstinner | link | issue22338 messages |
2014-09-10 21:37:26 | vstinner | create | |
|