Author r.david.murray
Recipients michael.foord, r.david.murray, rbcollins, vstinner
Date 2014-09-10.01:36:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1410312982.11.0.238062930521.issue19746@psf.upfronthosting.co.za>
In-reply-to
Content
Your patch isn't diffed against a revision from the cpython repo, and apparently didn't apply cleanly to tip, so no review link was generated.  I  uploaded a rebased patch to review, but don't actually have any line by line comments.

You are right about the docs.  Reading that, I thought it was saying that errors would have a list of the errors that show up in the summary as Errors=N, and not the ones that show up as Failures=N, which of course is completely off base for two reasons (but, then, I can never remember the difference between Failure and Error and always ignore what type the test failures are).

Anyway, you probably want to talk about actual error types.  I understand ImportError, but I have no idea what would trigger the 'Failed to call load_tests' error.  Nor is it clear what would be a fatal error (easier just to say which errors are trapped, I think). It should also be mentioned that the contents of the list are an error message followed by a full traceback.  And, frankly, I'm not sure why this is useful, and in particular why this implementation satisfies your use case.

(I'm more interested in the issue 7559 patch, but since it based on this one I don't think I can just rebase it to review it.)
History
Date User Action Args
2014-09-10 01:36:22r.david.murraysetrecipients: + r.david.murray, vstinner, rbcollins, michael.foord
2014-09-10 01:36:22r.david.murraysetmessageid: <1410312982.11.0.238062930521.issue19746@psf.upfronthosting.co.za>
2014-09-10 01:36:22r.david.murraylinkissue19746 messages
2014-09-10 01:36:20r.david.murraycreate