Author terry.reedy
Recipients BreamoreBoy, roger.serwy, terry.reedy
Date 2014-08-19.21:07:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1408482449.87.0.326459314158.issue22179@psf.upfronthosting.co.za>
In-reply-to
Content
As it is now, show_hit should have a comment something like this:

# On Windows, selection highight is visible while the dialog is open.
# A 'hit' tag is used while the dialog is open (see #22179).
# The 'hit' tag should be deleted when this dialog is closed.
# The 'sel' tag keeps the text marked after closing.

However, there is a slight bug in show_hit behavior. For example, finding 'i' in "def i(): this list is 'is' # is not" finds all 6 'i's, one after the other, but only the 4 in identifier, plain text, builtin, and comment are visibly highlighted.  The 2 in the keyword and string are not.  The selection tag, however, is visible on the 'i' of "is" or "'is'"after the dialog is closed. Checking ColorDelegator, I do not see an obvious reason for why two tags are handled differently.

If this cannot be fixed, we should try the alternate fix of making the sel tag visible and dump the found tag. Otherwise, I think I like the heavier highlighting while the dialog is open.
History
Date User Action Args
2014-08-19 21:07:29terry.reedysetrecipients: + terry.reedy, roger.serwy, BreamoreBoy
2014-08-19 21:07:29terry.reedysetmessageid: <1408482449.87.0.326459314158.issue22179@psf.upfronthosting.co.za>
2014-08-19 21:07:29terry.reedylinkissue22179 messages
2014-08-19 21:07:29terry.reedycreate