Author ned.deily
Recipients JayKrish, Saimadhav.Heblikar, Todd.Rovito, jesstess, ned.deily, rhettinger, roger.serwy, serhiy.storchaka, taleinat, terry.reedy
Date 2014-08-16.08:33:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1408177982.74.0.884026083776.issue17535@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for addressing the comments.  With linenumber-text-widget-v2.diff:

1. With Tk 8.4, the extension gets a bit further but still fails:

  File "/Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/__main__.py", line 9, in <module>
    idlelib.PyShell.main()
  File "/Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/PyShell.py", line 1570, in main
    shell = flist.open_shell()
  File "/Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/PyShell.py", line 327, in open_shell
    if not self.pyshell.begin():
  File "/Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/PyShell.py", line 1054, in begin
    (sys.version, sys.platform, self.COPYRIGHT, nosub))
  File "/Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/PyShell.py", line 1296, in write
    count = OutputWindow.write(self, s, tags, "iomark")
  File "/Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/OutputWindow.py", line 40, in write
    self.text.insert(mark, s, tags)
  File "/Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/Percolator.py", line 25, in insert
    self.top.insert(index, chars, tags)
  File "/Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/LineNumber.py", line 81, in insert
    self.changed_callback(get_end(self.delegate))
  File "/Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/LineNumber.py", line 158, in update_sidebar_text
    self.sidebar_text['width'] += width_difference
TypeError: Can't convert 'int' object to str implicitly

2. I just noticed that the (now) "Line Number" menu item has no visual indication of its state nor does it preserve its state over IDLE sessions.  The Code Context extension for edit windows does both: the menu item has a checkmark when enabled and that state is restored when IDLE is restarted.
History
Date User Action Args
2014-08-16 08:33:02ned.deilysetrecipients: + ned.deily, rhettinger, terry.reedy, taleinat, roger.serwy, jesstess, Todd.Rovito, serhiy.storchaka, JayKrish, Saimadhav.Heblikar
2014-08-16 08:33:02ned.deilysetmessageid: <1408177982.74.0.884026083776.issue17535@psf.upfronthosting.co.za>
2014-08-16 08:33:02ned.deilylinkissue17535 messages
2014-08-16 08:33:02ned.deilycreate