This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ned.deily
Recipients Lita.Cho, ned.deily, serhiy.storchaka, terry.reedy
Date 2014-07-25.21:12:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1406322739.21.0.133877339035.issue22065@psf.upfronthosting.co.za>
In-reply-to
Content
Nice insight, Serhly!  The patch addresses the menu concern I brought up in msg223631 of Issue21933.  I evaluated the patch with all three OS X Tk variants (Cocoa, Carbon, and X11) and it looked good to me.  The only review comment I have is that ideally, with Cocoa or Carbon Tk's, the "About ..." menu item in the "Apple" menu row would be customized to display the "aboutTurtleDemo" window; as it stands, it defaults to a Tk-supplied "about Tk" window.  The problem with doing that is that there are Tk-variant-specfic (Cocoa vs Carbon) ways to do that and it shouldn't be done at all for X11 so the implementation would get a bit messy;  the relevant code for IDLE is in macosxSupport.py towards the end of overrideRootMenu().  It's probably overkill for turtledemo so I'm OK with the patch as it stands (note I did not try it on any other platform).
History
Date User Action Args
2014-07-25 21:12:19ned.deilysetrecipients: + ned.deily, terry.reedy, serhiy.storchaka, Lita.Cho
2014-07-25 21:12:19ned.deilysetmessageid: <1406322739.21.0.133877339035.issue22065@psf.upfronthosting.co.za>
2014-07-25 21:12:19ned.deilylinkissue22065 messages
2014-07-25 21:12:18ned.deilycreate