Author r.david.murray
Recipients benjamin.peterson, docs@python, eric.araujo, ezio.melotti, georg.brandl, hynek, ncoghlan, nikratio, pitrou, r.david.murray, rhettinger, stutzbach
Date 2014-06-17.20:59:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1403038745.76.0.418771035787.issue21763@psf.upfronthosting.co.za>
In-reply-to
Content
I believe Antoine was suggesting that you suggest wording that would make it clear (rather than implied) that close was idempotent, but "This method has no effect if the file is already closed" seems pretty unambiguous to me, so I don't really see anything to do there (and presumably neither did you :)  Which means your patch here wasn't really what Antoine was suggesting.

But please don't hesitate to offer improvements in any context, solicited or not.  You just have to be prepared for pushback, because open source :)  And when shifting from mailing list to bug tracker, you may invoke a different audience with different perceptions of the problem.

Now, two alternate suggestions have been made here in reaction to your suggestion: strengthening the "this is also a specification" sense of the first sentence in the IO docs, and writing a separate section on implementing your own IO classes.  You could take a crack at either of those if you like.  Neither of these would have been suggested if you hadn't posted your thoughts on what to do and engaged in this discussion, so it is a positive contribution even if your patch is not accepted.
History
Date User Action Args
2014-06-17 20:59:05r.david.murraysetrecipients: + r.david.murray, georg.brandl, rhettinger, ncoghlan, pitrou, benjamin.peterson, stutzbach, ezio.melotti, eric.araujo, nikratio, docs@python, hynek
2014-06-17 20:59:05r.david.murraysetmessageid: <1403038745.76.0.418771035787.issue21763@psf.upfronthosting.co.za>
2014-06-17 20:59:05r.david.murraylinkissue21763 messages
2014-06-17 20:59:05r.david.murraycreate