Author tholzer
Recipients flox, gregory.p.smith, neologix, pitrou, tholzer, vstinner
Date 2014-05-26.03:42:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1401075722.98.0.0675258539887.issue20611@psf.upfronthosting.co.za>
In-reply-to
Content
I've also attached a potential patch for the C module Modules/socketmodule.c inside internal_connect().

A few notes:

This seems to work both without time-out and with time-out sockets (non-blocking).

One concern would be a signal storm prolonging the operation beyond the time-out. Should we keep track of the actual time taken in this loop and check it against the 'timeout' parameter ?

Also, I don't think we can call PyErr_CheckSignals() in this context. Does this need to happen at all ?
History
Date User Action Args
2014-05-26 03:42:03tholzersetrecipients: + tholzer, gregory.p.smith, pitrou, vstinner, flox, neologix
2014-05-26 03:42:02tholzersetmessageid: <1401075722.98.0.0675258539887.issue20611@psf.upfronthosting.co.za>
2014-05-26 03:42:02tholzerlinkissue20611 messages
2014-05-26 03:42:02tholzercreate