Author r.david.murray
Recipients barry, dveeden, r.david.murray, sYnfo, zvyn
Date 2014-05-17.15:04:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1400339053.27.0.226067517269.issue18540@psf.upfronthosting.co.za>
In-reply-to
Content
Milan: using 'localhost' is incorrect, since the string 'localhost' will not always resolve to the local host IP, while passing None to getaddrinfo will.

It is significant that the example fails.  We need a test for this case (the imap tests have been historically very poor, though we've improved that somewhat in the past few years).

Although it is a low-probability thing, someone might be depending on self.host being '' by default, so I think the better (and simpler) fix is to convert '' to None in the _create_socket method.
History
Date User Action Args
2014-05-17 15:04:13r.david.murraysetrecipients: + r.david.murray, barry, sYnfo, dveeden, zvyn
2014-05-17 15:04:13r.david.murraysetmessageid: <1400339053.27.0.226067517269.issue18540@psf.upfronthosting.co.za>
2014-05-17 15:04:13r.david.murraylinkissue18540 messages
2014-05-17 15:04:12r.david.murraycreate