Message217910
Caelyn: Thanks for the patch.
Some comments:
* Please use aliased=False instead of aliased=0 in the patch.
* It would be great if you could enhance the test a bit to actually check the return value. This would need a mock of the os.uname API for the test.
* Doc string "if "aliased" is true" should read "If aliased is true" |
|
Date |
User |
Action |
Args |
2014-05-05 07:48:01 | lemburg | set | recipients:
+ lemburg, ronaldoussoren, jackdied, Justin.Cappos, Christian.Clauss, math_foo |
2014-05-05 07:48:01 | lemburg | set | messageid: <1399276081.41.0.310525036648.issue7850@psf.upfronthosting.co.za> |
2014-05-05 07:48:01 | lemburg | link | issue7850 messages |
2014-05-05 07:48:00 | lemburg | create | |
|