This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eolson
Recipients eolson, jafo, jcea, johansen, ysj.ray
Date 2014-05-04.15:01:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1399215708.28.0.139988130844.issue2159@psf.upfronthosting.co.za>
In-reply-to
Content
Hi,
Thanks for finding those issues.  I attached a new patch.

a) Good find, I added the free() for gdbm.  ndbm doesn't need free().
b) Added the error check.  I don't know if a test can be made for this.  If there was a common way to patch C libraries in CPython, I would give that a try.
Also, do you know if we should check for the gdbm error before the dbm error, or does it not matter?
c) Yes, it looks like NULL is used here instead of 0.  Changed 0s to NULLS.

Let me know if you see anything else.
History
Date User Action Args
2014-05-04 15:01:48eolsonsetrecipients: + eolson, jafo, jcea, johansen, ysj.ray
2014-05-04 15:01:48eolsonsetmessageid: <1399215708.28.0.139988130844.issue2159@psf.upfronthosting.co.za>
2014-05-04 15:01:48eolsonlinkissue2159 messages
2014-05-04 15:01:48eolsoncreate