Author akira
Recipients akira, gregory.p.smith, jwilk, martin.panter, raylu
Date 2014-05-02.07:14:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1399014869.78.0.28144137829.issue21332@psf.upfronthosting.co.za>
In-reply-to
Content
to be clear: the test itself doesn't use threads, `python -mtest -j0`
runs tests using multiple *processes*, not threads. There is no issue.

If the test were to run in the presence of multiple threads then
the issue would be the *explicit* p.stdin.close() in the test (look
at the patch) that may close `p.stdin.fileno()` that might be opened
in another thread (unrelated to the current test) after it was
closed in the test the first time. I could call
`getattr(p.stdin, 'buffer', p.stdin).raw.fd = -1` to avoid trying to
close the fd the second time but I don't think it is necessary.

I don't think tests are expected to run in the presence of multiple
threads unless they start them.
History
Date User Action Args
2014-05-02 07:14:29akirasetrecipients: + akira, gregory.p.smith, jwilk, martin.panter, raylu
2014-05-02 07:14:29akirasetmessageid: <1399014869.78.0.28144137829.issue21332@psf.upfronthosting.co.za>
2014-05-02 07:14:29akiralinkissue21332 messages
2014-05-02 07:14:29akiracreate