Author martin.panter
Recipients akira, gregory.p.smith, jwilk, martin.panter, raylu
Date 2014-05-02.06:14:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1399011251.67.0.833647920588.issue21332@psf.upfronthosting.co.za>
In-reply-to
Content
On second thoughts maybe the idea of closing the input is not such a good idea in practice. Once you call os.close() on the file descriptor, that descriptor becomes unallocated, and I can’t see any way to prevent p.stdin.close(), Popen() context, destructors, etc from trying to close the file descriptor again. If the Python test suite is ever multithreaded (I’m not really familiar with it), that would be a real problem. In any case closing an unallocated file descriptor is a bad idea. Maybe the deadlocking version is more appropriate after all.
History
Date User Action Args
2014-05-02 06:14:11martin.pantersetrecipients: + martin.panter, gregory.p.smith, jwilk, akira, raylu
2014-05-02 06:14:11martin.pantersetmessageid: <1399011251.67.0.833647920588.issue21332@psf.upfronthosting.co.za>
2014-05-02 06:14:11martin.panterlinkissue21332 messages
2014-05-02 06:14:11martin.pantercreate