Author Jim.Jewett
Recipients Jim.Jewett, NewerCookie, alanmcintyre, amaury.forgeotdarc, apolkosnik, berker.peksag, chuck, ethan.furman, francismb, georg.brandl, gregory.p.smith, ncoghlan, ronaldoussoren, serhiy.storchaka, terry.reedy
Date 2014-04-30.22:00:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CA+OGgf5tw2mfyuaHTrn=H4rgU47eE36tBmEfEUR1V5cAG7MDhg@mail.gmail.com>
In-reply-to
Content
On Wed, Apr 30, 2014 at 3:05 PM, Adam Polkosnik wrote:

> test.zip up there is the test case for this change. Is there any other test case needed?

ah; I see the confusion.  test.zip is test *data*.  When I asked for a
test *case*, I meant something that ensures the data will be used to
actually run the test automatically.

Typically, that would involve adding something to
Lib/test/test_zipfile.py.  I'm guessing it would be easiest to add a
new class inheriting from unittest.TestCase and opening test.zip in
the setUp, then using a bunch of assert* methods to verify that the
file was read and interpreted correctly.

-jJ
History
Date User Action Args
2014-04-30 22:00:30Jim.Jewettsetrecipients: + Jim.Jewett, georg.brandl, terry.reedy, gregory.p.smith, ronaldoussoren, amaury.forgeotdarc, ncoghlan, alanmcintyre, NewerCookie, chuck, ethan.furman, francismb, berker.peksag, serhiy.storchaka, apolkosnik
2014-04-30 22:00:30Jim.Jewettlinkissue6839 messages
2014-04-30 22:00:30Jim.Jewettcreate