Author pitrou
Recipients Anton.Afanasyev, pitrou, rhettinger
Date 2014-04-29.08:39:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1398760762.35.0.930166917982.issue21321@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks. Could you also add a test for the islice_reduce additions? Or is it already tested?
I suspect there's a reference leak there: after calling PyObject_GetIter, you should always Py_DECREF(empty_list).
Also, with the "O" code, Py_BuildValue will take a new reference to empty_it, so you should use the "N" code instead.
History
Date User Action Args
2014-04-29 08:39:22pitrousetrecipients: + pitrou, rhettinger, Anton.Afanasyev
2014-04-29 08:39:22pitrousetmessageid: <1398760762.35.0.930166917982.issue21321@psf.upfronthosting.co.za>
2014-04-29 08:39:22pitroulinkissue21321 messages
2014-04-29 08:39:22pitroucreate