Author tim.golden
Recipients Kim.Gräsman, brian.curtin, python-dev, terry.reedy, tim.golden, tim.peters
Date 2014-04-29.07:48:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <535F5933.6050207@timgolden.me.uk>
In-reply-to <1398750935.74.0.232556577851.issue18314@psf.upfronthosting.co.za>
Content
Yes, now that the custom allocator / tracing stuff is in place: 
otherwise there's no way for custom allocation or tracing to occur. 
Please go ahead and rework the patch when you have the time.

Also, since the setup of the reparse header is such an underdocumented 
nightmare, please add as much commentary as possible around the choice 
of allocations & offsets. I was reviewing your code with an eye on the 
various MSDN pages and examples and I still wasn't always able to follow 
your choices.

(BTW I'm not convinced that the PyMem change was the problem since the 
PyMem_Raw* functions simply hand off to malloc/free unless there's a 
custom allocator. Unless of course the missing memset-0 was significant 
here).
History
Date User Action Args
2014-04-29 07:48:00tim.goldensetrecipients: + tim.golden, tim.peters, terry.reedy, brian.curtin, python-dev, Kim.Gräsman
2014-04-29 07:48:00tim.goldenlinkissue18314 messages
2014-04-29 07:48:00tim.goldencreate