Author jesstess
Recipients Trundle, amaury.forgeotdarc, eric.araujo, ezio.melotti, jesstess, pitrou, vstinner
Date 2014-04-28.03:36:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1398656175.44.0.8804877825.issue13204@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for reporting this and providing a patch, Trundle.

The Python 3 patch didn't apply cleanly anymore, so I regenerated it and added tests for sys.version_info and sys.getwindowsversion.

* The patch passes `make patchcheck`
* The full test suite passes with this patch.
* Testing manually, without this patch each of the following segfaults, and with the patch they raise errors instead:

import sys; sys.flags.__new__(type(sys.flags))
import sys; sys.version_info.__new__(type(sys.version_info))
import sys; sys.getwindowsversion().__new__(type(sys.getwindowsversion()))

One important caveat is that while I confirmed the sys.getwindowsversion segfault on Windows, I don't have Visual Studio set up so I couldn't build and test the new test for sys.getwindowsversion (I ran the full test suite on OSX, where this test is skipped).
History
Date User Action Args
2014-04-28 03:36:15jesstesssetrecipients: + jesstess, amaury.forgeotdarc, pitrou, vstinner, ezio.melotti, eric.araujo, Trundle
2014-04-28 03:36:15jesstesssetmessageid: <1398656175.44.0.8804877825.issue13204@psf.upfronthosting.co.za>
2014-04-28 03:36:15jesstesslinkissue13204 messages
2014-04-28 03:36:15jesstesscreate