Message216849
Christian's patch is good.It helps in setting the socket.makefile file descriptor to a well behaving well file close wrapper and thus will help us prevent some tricky fd close issues.
I added tests for coverage to ensure that we are asserting the type and covering all the methods in urllib.response. Attaching the patch built on top of Chritians one. |
|
Date |
User |
Action |
Args |
2014-04-19 07:34:44 | orsenthil | set | recipients:
+ orsenthil, ctheune, pitrou, giampaolo.rodola, r.david.murray, bbrazil, sspapilin |
2014-04-19 07:34:44 | orsenthil | set | messageid: <1397892884.36.0.754928748544.issue15002@psf.upfronthosting.co.za> |
2014-04-19 07:34:44 | orsenthil | link | issue15002 messages |
2014-04-19 07:34:44 | orsenthil | create | |
|