Message216285
On Tue, Apr 15, 2014, at 2:34, Dima Tisnek wrote:
>
> Dima Tisnek added the comment:
>
> Banjamin, Your patch looks good to me!
>
> I have a small concern regarding "We now know we will succeed..." --
> should there be a test case to make sure fstat test here matches whatever
> test is/was done on a lower level?
>
> Or is your code now such that it will explicitly succeed because it
> doesn't call anything that can fail after the comment?
That's what I mean. |
|
Date |
User |
Action |
Args |
2014-04-15 12:58:39 | benjamin.peterson | set | recipients:
+ benjamin.peterson, python-dev, Dima.Tisnek |
2014-04-15 12:58:39 | benjamin.peterson | link | issue21191 messages |
2014-04-15 12:58:39 | benjamin.peterson | create | |
|