This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nikratio
Recipients benjamin.peterson, hynek, loewis, nikratio, pitrou, stutzbach, vstinner
Date 2014-04-15.01:31:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1397525516.38.0.064344926276.issue20578@psf.upfronthosting.co.za>
In-reply-to
Content
Attached is an updated patch that 
 - removes the code duplication in _pyio.BufferedIOBase
 - adds an internal _readinto helper method to _pyio.BufferedReader that makes the implementation similar to io.BufferedReader.
 - implements _pyio.BuffereadReader.{readinto,readinto1} in terms of the new helper method and, as a side effect, also increases their performance.


Performance of the _pyio implementation on my system is:

pre-patch:
readinto:  5.130e+00 seconds
readinto1 not available

post-patch:
readinto:  2.039e+00 seconds
readinto1: 1.995e+00 seconds
History
Date User Action Args
2014-04-15 01:31:56nikratiosetrecipients: + nikratio, loewis, pitrou, vstinner, benjamin.peterson, stutzbach, hynek
2014-04-15 01:31:56nikratiosetmessageid: <1397525516.38.0.064344926276.issue20578@psf.upfronthosting.co.za>
2014-04-15 01:31:56nikratiolinkissue20578 messages
2014-04-15 01:31:56nikratiocreate