Author mrabarnett
Recipients Lucretiel, ezio.melotti, mrabarnett, serhiy.storchaka
Date 2014-04-04.18:49:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1396637374.23.0.844365787024.issue20998@psf.upfronthosting.co.za>
In-reply-to
Content
> > -                (!ctx->match_all || ctx->ptr == state->end)) {
> > +                ctx->ptr == state->end) {
> 
> Why this check is not needed anymore?
> 
After stepping through the code for that regex that fails, I concluded 
that the condition shouldn't depend on ctx->match_all at that point 
after all.

> > -                    status = SRE(match)(state, pattern + 2*prefix_skip);
> > +                    status = SRE(match)(state, pattern + 2*prefix_skip, 
> state->match_all);
> 
> > -            status = SRE(match)(state, pattern + 2);
> > +            status = SRE(match)(state, pattern + 2, state->match_all);
> 
> state->match_all is used but it is never initialized.

I thought I'd initialised it in all the places it's used.

I admit that I find the code a little hard to follow at times... :-(
History
Date User Action Args
2014-04-04 18:49:34mrabarnettsetrecipients: + mrabarnett, ezio.melotti, serhiy.storchaka, Lucretiel
2014-04-04 18:49:34mrabarnettsetmessageid: <1396637374.23.0.844365787024.issue20998@psf.upfronthosting.co.za>
2014-04-04 18:49:34mrabarnettlinkissue20998 messages
2014-04-04 18:49:33mrabarnettcreate