Author terry.reedy
Recipients Todd.Rovito, bagratte, edmond.burnett, eric.araujo, ezio.melotti, kjohnson, python-dev, roger.serwy, terry.reedy, westley.martinez
Date 2014-04-01.00:36:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1396312568.84.0.572973699705.issue17390@psf.upfronthosting.co.za>
In-reply-to
Content
As far as I can tell, there are 4 window classes to be concerned with. (Dialogs would be a separate issue.)

EditorWindow
|- PyShellEditorWindow - EW+breakpoints, replaces WE in PyShellFileList
|- OutputWindow - used by Find in Files
   |- PyShell - the visible shell window

PyShellEditorWindow does not override the title methods and is of no concern to us.

If we want the title for all these windows to start with 'Python', we should 'factor' that out and start with it at the beginning of EditorWindow.saved_change_hook (and change other things in EW). Thinking ahead, another possible use for OutputWindow is for containing the result of running an external program on a file. I think that a leading 'Python' would be fine something like
  Python: PyFlakes output for OutputWindow.py

Adding the flexibility of a title parameter to OutputWindow instead of EditorWindow seems about right. If we do that, the override of .short_title for PyShell in the first patch should be removed and the title passed in to the one and only call that creates a PyShell (PyShell.py, 315).

I would like to add some minimal automated tests (maybe in a new test_misc.py file) using either mock classes or unittest.mock (which I have not used yet).
History
Date User Action Args
2014-04-01 00:36:09terry.reedysetrecipients: + terry.reedy, kjohnson, ezio.melotti, roger.serwy, eric.araujo, Todd.Rovito, westley.martinez, python-dev, bagratte, edmond.burnett
2014-04-01 00:36:08terry.reedysetmessageid: <1396312568.84.0.572973699705.issue17390@psf.upfronthosting.co.za>
2014-04-01 00:36:08terry.reedylinkissue17390 messages
2014-04-01 00:36:06terry.reedycreate