Message214141
Thanks for the code review Antoine.
It seems like the only non-trivial comment is regarding the `append` and `exclusive` arguments:
"I don't think "append" and "exclusive" deserve to be arguments here.
write_bytes()/write_text() is a convenience method for the common use case."
Are you suggesting that these features be removed? I think it'll be really sad. I don't think that just because someone wants to use modes 'a' or 'x' it means that they should now write a with clause instead of using our one-liner. Just because something is made for convenience, doesn't mean it should be crippled. |
|
Date |
User |
Action |
Args |
2014-03-19 21:37:27 | cool-RR | set | recipients:
+ cool-RR, pitrou, cjwelborn |
2014-03-19 21:37:27 | cool-RR | set | messageid: <1395265047.05.0.823197664535.issue20218@psf.upfronthosting.co.za> |
2014-03-19 21:37:27 | cool-RR | link | issue20218 messages |
2014-03-19 21:37:26 | cool-RR | create | |
|