Author cool-RR
Recipients cjwelborn, cool-RR, pitrou
Date 2014-03-19.21:37:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1395265047.05.0.823197664535.issue20218@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the code review Antoine.

It seems like the only non-trivial comment is regarding the `append` and `exclusive` arguments:

"I don't think "append" and "exclusive" deserve to be arguments here.
write_bytes()/write_text() is a convenience method for the common use case."

Are you suggesting that these features be removed? I think it'll be really sad. I don't think that just because someone wants to use modes 'a' or 'x' it means that they should now write a with clause instead of using our one-liner. Just because something is made for convenience, doesn't mean it should be crippled.
History
Date User Action Args
2014-03-19 21:37:27cool-RRsetrecipients: + cool-RR, pitrou, cjwelborn
2014-03-19 21:37:27cool-RRsetmessageid: <1395265047.05.0.823197664535.issue20218@psf.upfronthosting.co.za>
2014-03-19 21:37:27cool-RRlinkissue20218 messages
2014-03-19 21:37:26cool-RRcreate